fix(deploy): address M2.1 review nits — comparer consistency + comments (#22)
- connection-name capable-set comparer kept as StringComparer.Ordinal: FlatteningService and SemanticValidator use all-ordinal name-keyed dictionaries throughout; OrdinalIgnoreCase would be inconsistent with the rest of the binding-resolution path — added comment documenting this - IsAlarmCapable protocol-match confirmed consistent with DataConnectionFactory (both OrdinalIgnoreCase); added case-insensitive InlineData variants (OPCUA, opcua, mxgateway, MXGATEWAY) to lock the contract - clarified FlatteningPipeline comment: "filters connections by alarm-capable protocol, then collects their names" (was "maps from the protocol string") - added DataConnectionLayer/DataConnectionFactory.cs path reference to AlarmCapableProtocols sync-risk comment
This commit is contained in:
@@ -114,8 +114,14 @@ public class FlatteningPipeline : IFlatteningPipeline
|
||||
|
||||
// Compute the alarm-capable connection-name set so the semantic validator
|
||||
// can gate native-alarm-source bindings. "Alarm-capable" matches the DCL
|
||||
// runtime decision (DataConnectionActor: _adapter is IAlarmSubscribableConnection),
|
||||
// mapped from the protocol string via the shared AlarmCapableProtocols helper.
|
||||
// runtime decision (DataConnectionActor: _adapter is IAlarmSubscribableConnection);
|
||||
// here we filter connections by alarm-capable protocol, then collect their names.
|
||||
//
|
||||
// StringComparer.Ordinal is intentional: connection names are stored and
|
||||
// matched as authored throughout the pipeline (all other name-keyed
|
||||
// dictionaries in FlatteningService and SemanticValidator use the same
|
||||
// case-sensitive semantics). OrdinalIgnoreCase would be inconsistent with
|
||||
// the rest of the binding-resolution path.
|
||||
var alarmCapableConnectionNames = dataConnections.Values
|
||||
.Where(c => AlarmCapableProtocols.IsAlarmCapable(c.Protocol))
|
||||
.Select(c => c.Name)
|
||||
|
||||
Reference in New Issue
Block a user