refactor(deploy): retire cross-cluster DeployInstanceCommand wire path (config now fetched)

2026-06-26 14:32:47 -04:00
parent 5c2db9fe70
commit 3e64959582
7 changed files with 24 additions and 92 deletions
@@ -154,9 +154,9 @@ public class SiteReplicationActor : ReceiveActor
    {
        if (string.IsNullOrEmpty(msg.CentralFetchBaseUrl))
        {
-            // The still-present direct DeployInstanceCommand wire path (retired in Task 14)
-            // replicates with empty coords; there is nothing to fetch. Skip quietly rather
-            // than calling FetchAsync("") and logging an error — T18 reconciliation backstops.
+            // The direct DeployInstanceCommand cross-cluster wire path was retired (Task 14).
+            // This guard is a defensive fallback: skip quietly rather than calling FetchAsync("")
+            // and logging a spurious error. T18 reconciliation backstops any missed writes.
            _logger.LogDebug(
                "No fetch coords for {Instance} (deployment {DeploymentId}) — skipping replicated fetch; T18 reconciliation is the backstop",
                msg.InstanceName, msg.DeploymentId);