feat(host): build the process logger through the shared AddZbSerilog bootstrap (#94)

Switch ScadaBridge from its own LoggerConfigurationFactory to AddZbSerilog
(ZB.MOM.WW.Telemetry(.Serilog) 0.1.0 -> 0.2.0) using the two 0.2.0 hooks:

- MinimumLevelGovernor: ScadaBridge:Logging:MinimumLevel, applied after
  ReadFrom.Configuration so it outranks Serilog:MinimumLevel (never null, so the
  floor never defers to the Serilog key; Override:* namespace entries still apply;
  the one-shot conflict / unparseable-value warnings are unchanged).
- ConfigureLogger: the standby active-node exclusion filter (register row 71),
  the configured node identity (the shared bootstrap stamps NodeHostname from
  the machine name and skips empty values; an overwriting enricher keeps the
  configured ScadaBridge:Node values verbatim), Enrich.FromLogContext and the
  ExecutionLogCaptureSink.

ScadaBridgeLogging runs AddZbSerilog on a small pre-host builder and Program
installs the result as the static Log.Logger; both web hosts keep UseSerilog()
over it. One logger and one file-sink handle per process, usable before the
host is built (startup banner, warnings, pre-host Fatal), by SerilogAkkaLogger,
and after the host is disposed (shutdown line, unexpected-termination Fatal) —
AddZbSerilog's own DI registration would leave Log.Logger alone and have the
host dispose the logger.

LoggerConfigurationFactory is deleted (nothing else used it). Tests: existing
logging/standby/sink tests now run through the new pipeline, plus
ScadaBridgeLoggingParityTests (level precedence, Override:* still applies,
one-shot warning, configured identity incl. NodeHostname != MachineName and empty
SiteId, exact property set of a plain line, trace_id/span_id). Mutation-checked:
governor deferring, filter removed, identity enricher removed, FromLogContext
removed, capture sink removed each fail tests.

Claude-Session: https://claude.ai/code/session_01GT67ACmpMR7b9LGRPLijMi
This commit is contained in:
Joseph Doherty
2026-11-12 13:53:26 -05:00
parent dd4f1c2aa3
commit 2d2e9f35c5
15 changed files with 575 additions and 274 deletions
+2 -1
View File
@@ -159,6 +159,7 @@ On site nodes, the Host must also use `WebApplication.CreateBuilder` (not `Host.
The Host must configure Serilog as the logging provider with:
- **Built by the family's shared bootstrap (Gitea #94).** `ScadaBridgeLogging` builds the logger with `AddZbSerilog` (`ZB.MOM.WW.Telemetry.Serilog` 0.2.0+) and two ScadaBridge hooks: `MinimumLevelGovernor` (`ScadaBridge:Logging:MinimumLevel`, applied after `ReadFrom.Configuration` so it outranks `Serilog:MinimumLevel`; namespace `Override:*` entries still apply) and `ConfigureLogger` (the standby `active-node` filter below, the configured node identity, `Enrich.FromLogContext`, `ExecutionLogCaptureSink`). It runs `AddZbSerilog` on a small pre-host builder and `Program` installs the result as the static `Log.Logger`; both web hosts call `UseSerilog()` over it, so there is one logger and one file-sink handle per process and the static logger stays usable before the host is built and after it is disposed.
- Configuration-driven sink setup (console and file sinks at minimum).
- Automatic enrichment of every log entry with `SiteId`, `NodeHostname`, and `NodeRole` properties sourced from `NodeConfiguration`.
- Structured (machine-parseable) output format.
@@ -228,7 +229,7 @@ renders it as a *No self-heal* warning badge. See
### Standby health-check log noise
`LoggerConfigurationFactory` installs one Serilog exclusion filter, for the by-design standby
`ScadaBridgeLogging` (via the shared bootstrap's `ConfigureLogger` hook) installs one Serilog exclusion filter, for the by-design standby
verdict of the `active-node` probe (register row 71).
`DefaultHealthCheckService` logs one line per check per probe and picks the level from the verdict —