fix(kpi): untracked projected fold fetch — fold reads no longer flood the change tracker (plan R2-04 T1)

2026-07-13 09:42:31 -04:00
parent 1429ddaa0e
commit 29c1286943
2 changed files with 30 additions and 0 deletions
@@ -386,6 +386,26 @@ public class KpiHistoryRepositoryTests
        Assert.Equal(new[] { 3d, 4d }, remaining.Select(p => p.Value).ToArray());
    }

+    [Fact]
+    public async Task FoldHourlyRollups_DoesNotTrack_KpiSampleEntities()
+    {
+        await using var ctx = NewContext();
+        var repo = new KpiHistoryRepository(ctx);
+        await repo.RecordSamplesAsync(new[]
+        {
+            Sample("NotificationOutbox", "queueDepth", "Global", null, 5, Base.AddMinutes(10)),
+            Sample("NotificationOutbox", "queueDepth", "Global", null, 7, Base.AddMinutes(50)),
+        });
+        ctx.ChangeTracker.Clear(); // isolate the fold's tracking behavior from the seed
+
+        await repo.FoldHourlyRollupsAsync(Base, Base.AddHours(1));
+
+        // The fold READS samples and WRITES rollups; the read must not register
+        // thousands of read-only KpiSample entries for DetectChanges to re-scan
+        // (arch-review 04 round 2, R2).
+        Assert.Empty(ctx.ChangeTracker.Entries<KpiSample>());
+    }
+
    // Local mirror of the repo's private hour-truncation, for cutoff assertions.
    private static DateTime TruncateHour(DateTime utc) =>
        new(utc.Year, utc.Month, utc.Day, utc.Hour, 0, 0, DateTimeKind.Utc);