feat(localdb): register the consolidated site database in the composition root

Task 3. Site nodes now open one ZB.MOM.WW.LocalDb-managed database holding OperationTracking and site_events as replicated tables. SiteLocalDbSetup.OnReady applies both schemas and then RegisterReplicated's them. That order is load-bearing and easy to get silently wrong: capture is trigger-based CDC, so rows written before registration are never captured or snapshotted - they would be invisible to the peer forever, with no error anywhere. Storage ships UNCONDITIONALLY, no feature flag. With no peer configured LocalDb is just a local SQLite file, so this is behaviour-equivalent to what site nodes do today. Replication is opt-in and lands in Program.cs (Task 7), which owns the gRPC host the sync endpoint needs. Config: LocalDb:Path added to all EIGHT site-node appsettings (the plan said six - docker-env2's site-x pair exists too), plus the dev template and the wonder-app-vd03 production sample. All ten are required, not optional: LocalDbOptions.Path is validated with ValidateOnStart, so a site node without it fails fast at startup. That is the desired posture, and it is what caught ActorPathTests - the one Host fixture that actually starts a host - whose config now sets the path too. Note the path choice fixes an existing data-loss bug in passing: site-tracking.db and site_events.db both defaulted to CWD-relative paths (/app/...), outside the mounted volume, so they were silently lost on every container recreate. The consolidated database lives on /app/data. Tests are container-built against the REAL SiteServiceRegistration.Configure, not a hand-assembled ServiceCollection - this family has shipped three wiring defects that only a real graph would catch (inert Secrets replicator 0.2.0, singleton deadlock 0.2.2, Secrets.Ui missing IAuditWriter). They assert the library's own view of what is registered rather than that we called the right method. Verified (all after the change): dotnet build ZB.MOM.WW.ScadaBridge.slnx -> 0 Error(s), 0 Warning(s) Host.Tests -> 294 passed (5 new, red-first) SiteRuntime.Tests -> 530 passed CentralUI.Tests -> 925 passed Commons.Tests -> 684 passed Communication.Tests -> 312 passed SiteEventLogging.Tests-> 70 passed Claude-Session: https://claude.ai/code/session_01BL2Vu1ESDQ9SCN4gVKkdts
2026-07-19 03:36:54 -04:00
parent 2742d54c9f
commit 2977e6c45c
13 changed files with 274 additions and 0 deletions
@@ -0,0 +1,133 @@
+using Microsoft.AspNetCore.Builder;
+using Microsoft.Extensions.Configuration;
+using Microsoft.Extensions.DependencyInjection;
+using ZB.MOM.WW.LocalDb;
+using ZB.MOM.WW.ScadaBridge.Host;
+using ZB.MOM.WW.ScadaBridge.Host.Actors;
+
+namespace ZB.MOM.WW.ScadaBridge.Host.Tests;
+
+/// <summary>
+/// LocalDb Phase 1 (Task 3) — locks the consolidated site database into the REAL site
+/// composition root.
+/// <para>
+/// These tests build the actual container from
+/// <see cref="SiteServiceRegistration.Configure"/> rather than asserting on a
+/// hand-assembled <c>ServiceCollection</c>. That is deliberate and load-bearing: this
+/// family has now shipped three wiring defects that only a container-built graph would
+/// have caught — the Secrets Akka replicator that registered into a no-op sink (0.2.0),
+/// the singleton cycle that deadlocked a real host (0.2.2), and Secrets.Ui's missing
+/// <c>IAuditWriter</c> that 500'd only behind a login wall (ScadaBridge#22). A test that
+/// merely checks "AddZbLocalDb was called" would have passed in every one of those cases.
+/// </para>
+/// </summary>
+public class SiteLocalDbWiringTests : IDisposable
+{
+    private readonly WebApplication _host;
+    private readonly string _tempDbPath;
+    private readonly string _tempSiteDbPath;
+    private readonly string _tempTrackingDbPath;
+
+    public SiteLocalDbWiringTests()
+    {
+        var stamp = Guid.NewGuid();
+        _tempDbPath = Path.Combine(Path.GetTempPath(), $"scadabridge_localdb_{stamp}.db");
+        _tempSiteDbPath = Path.Combine(Path.GetTempPath(), $"scadabridge_site_{stamp}.db");
+        _tempTrackingDbPath = Path.Combine(Path.GetTempPath(), $"scadabridge_track_{stamp}.db");
+
+        var builder = WebApplication.CreateBuilder();
+        builder.Configuration.Sources.Clear();
+        builder.Configuration.AddInMemoryCollection(new Dictionary<string, string?>
+        {
+            ["ScadaBridge:Node:Role"] = "Site",
+            ["ScadaBridge:Node:NodeName"] = "node-a",
+            ["ScadaBridge:Node:NodeHostname"] = "test-site",
+            ["ScadaBridge:Node:SiteId"] = "TestSite",
+            ["ScadaBridge:Node:RemotingPort"] = "0",
+            ["ScadaBridge:Node:GrpcPort"] = "0",
+            ["ScadaBridge:Database:SiteDbPath"] = _tempSiteDbPath,
+            ["ScadaBridge:OperationTracking:ConnectionString"] = $"Data Source={_tempTrackingDbPath}",
+            ["ScadaBridge:Cluster:SeedNodes:0"] = "akka.tcp://scadabridge@localhost:2551",
+            ["ScadaBridge:Cluster:SeedNodes:1"] = "akka.tcp://scadabridge@localhost:2552",
+
+            // The consolidated site database. No Replication section at all — this
+            // fixture is also the default-OFF pin: storage must work standalone.
+            ["LocalDb:Path"] = _tempDbPath,
+        });
+
+        builder.Services.AddGrpc();
+        builder.Services.AddSingleton<ZB.MOM.WW.ScadaBridge.Communication.Grpc.SiteStreamGrpcServer>();
+
+        SiteServiceRegistration.Configure(builder.Services, builder.Configuration);
+
+        AkkaHostedServiceRemover.RemoveAkkaHostedServiceOnly(builder.Services);
+
+        _host = builder.Build();
+    }
+
+    public void Dispose()
+    {
+        (_host as IDisposable)?.Dispose();
+        foreach (var path in new[] { _tempDbPath, _tempSiteDbPath, _tempTrackingDbPath })
+        {
+            try { File.Delete(path); } catch { /* best effort */ }
+        }
+
+        GC.SuppressFinalize(this);
+    }
+
+    [Fact]
+    public void Site_Resolves_ILocalDb()
+    {
+        Assert.NotNull(_host.Services.GetService<ILocalDb>());
+    }
+
+    [Fact]
+    public void Site_LocalDb_RegistersBothReplicatedTables()
+    {
+        // The whole point of Phase 1. If onReady silently failed to register these,
+        // storage would still work and every other test would pass — the pair would
+        // just never replicate anything. Assert on the library's own view of what is
+        // registered, not on our belief that we called it.
+        var db = _host.Services.GetRequiredService<ILocalDb>();
+
+        Assert.Contains("OperationTracking", db.ReplicatedTables.Keys);
+        Assert.Contains("site_events", db.ReplicatedTables.Keys);
+    }
+
+    [Fact]
+    public void Site_LocalDb_ReplicatedTablesHaveExplicitPrimaryKeys()
+    {
+        // RegisterReplicated refuses a table with no explicit PK, so reaching this
+        // assertion at all proves the DDL ran before registration. The PK names are
+        // pinned because they are what last-writer-wins conflict resolution keys on.
+        var db = _host.Services.GetRequiredService<ILocalDb>();
+
+        Assert.Equal(
+            ["TrackedOperationId"], db.ReplicatedTables["OperationTracking"].PkColumns);
+        Assert.Equal(["id"], db.ReplicatedTables["site_events"].PkColumns);
+    }
+
+    [Fact]
+    public void Site_LocalDb_IsASingleton()
+    {
+        // AddZbLocalDb is one-DB-per-process and first-registration-wins. Two
+        // instances would mean two SQLite handles and two trigger installations
+        // against the same file.
+        var first = _host.Services.GetRequiredService<ILocalDb>();
+        var second = _host.Services.GetRequiredService<ILocalDb>();
+
+        Assert.Same(first, second);
+    }
+
+    [Fact]
+    public void Site_LocalDb_CreatesTheConfiguredFile()
+    {
+        // Resolving is what triggers onReady; the file should exist afterwards at the
+        // configured path and not somewhere CWD-relative.
+        _ = _host.Services.GetRequiredService<ILocalDb>();
+
+        Assert.True(File.Exists(_tempDbPath),
+            $"Expected the consolidated site database at '{_tempDbPath}'.");
+    }
+}