feat(comm): ack site health reports end-to-end (SiteHealthReportAck, additive contract)

2026-07-08 16:09:08 -04:00
parent f7b9d342e4
commit 17af376a8e
4 changed files with 105 additions and 3 deletions
@@ -0,0 +1,66 @@
+using Akka.Actor;
+using Akka.TestKit.Xunit2;
+using Microsoft.Extensions.DependencyInjection;
+using NSubstitute;
+using ZB.MOM.WW.ScadaBridge.Commons.Entities.Sites;
+using ZB.MOM.WW.ScadaBridge.Commons.Interfaces.Repositories;
+using ZB.MOM.WW.ScadaBridge.Commons.Messages.Health;
+using ZB.MOM.WW.ScadaBridge.Commons.Types;
+using ZB.MOM.WW.ScadaBridge.Commons.Types.Enums;
+using ZB.MOM.WW.ScadaBridge.Communication.Actors;
+using ZB.MOM.WW.ScadaBridge.HealthMonitoring;
+
+namespace ZB.MOM.WW.ScadaBridge.Communication.Tests;
+
+/// <summary>
+/// Review 01 [Medium]: site→central health reports were fire-and-forget, so a lost
+/// report was invisible to the sender. These tests pin the new end-to-end ack:
+/// the site actor replies not-accepted when it has no central ClusterClient, and the
+/// central actor processes + acks a report it receives.
+/// </summary>
+public class HealthReportAckTests : TestKit
+{
+    private readonly CommunicationOptions _options = new();
+
+    private static SiteHealthReport SampleReport(long seq, string siteId = "site-a") =>
+        new(siteId, seq, DateTimeOffset.UtcNow,
+            new Dictionary<string, ConnectionHealth>(),
+            new Dictionary<string, TagResolutionStatus>(),
+            0, 0, new Dictionary<string, int>(), 0, 0, 0, 0);
+
+    [Fact]
+    public void SiteCommunicationActor_NoCentralClient_RepliesNotAccepted()
+    {
+        var dmProbe = CreateTestProbe();
+        var siteComm = Sys.ActorOf(Props.Create(() =>
+            new SiteCommunicationActor("site-a", _options, dmProbe.Ref)));
+        // No RegisterCentralClient sent => _centralClient is null.
+        siteComm.Tell(SampleReport(seq: 7));
+        var ack = ExpectMsg<SiteHealthReportAck>();
+        Assert.False(ack.Accepted);
+        Assert.Equal(7, ack.SequenceNumber);
+        Assert.Equal("site-a", ack.SiteId);
+    }
+
+    [Fact]
+    public void CentralCommunicationActor_OnReport_ProcessesAndAcks()
+    {
+        var mockRepo = Substitute.For<ISiteRepository>();
+        mockRepo.GetAllSitesAsync(Arg.Any<CancellationToken>()).Returns(new List<Site>());
+        var aggregator = Substitute.For<ICentralHealthAggregator>();
+
+        var services = new ServiceCollection();
+        services.AddScoped(_ => mockRepo);
+        services.AddSingleton(aggregator);
+        var sp = services.BuildServiceProvider();
+
+        var siteClientFactory = Substitute.For<ISiteClientFactory>();
+        var actor = Sys.ActorOf(Props.Create(() => new CentralCommunicationActor(sp, siteClientFactory)));
+
+        actor.Tell(SampleReport(seq: 3));
+        var ack = ExpectMsg<SiteHealthReportAck>();
+        Assert.True(ack.Accepted);
+        Assert.Equal(3, ack.SequenceNumber);
+        AwaitAssert(() => aggregator.Received().ProcessReport(Arg.Is<SiteHealthReport>(r => r.SequenceNumber == 3)));
+    }
+}