Resolve all high-severity architecture review findings

2026-09-09 16:13:58 -04:00
parent 8bfe65512e
commit 146a13238f
192 changed files with 3160 additions and 753 deletions
@@ -0,0 +1,55 @@
+using Microsoft.Data.Sqlite;
+using Microsoft.Extensions.Logging.Abstractions;
+using Moq;
+using ZB.MOM.WW.ScadaBridge.Commons.Interfaces.Services;
+using ZB.MOM.WW.ScadaBridge.SiteRuntime.Scripts;
+
+namespace ZB.MOM.WW.ScadaBridge.SiteRuntime.Tests.Scripts;
+
+public class AuditingDbTransactionTests
+{
+    [Theory]
+    [InlineData(false)]
+    [InlineData(true)]
+    public async Task SR11_TransactionConnectionAndCommandReadbackRemainAudited(bool asynchronous)
+    {
+        var inner = new SqliteConnection("Data Source=:memory:");
+        await inner.OpenAsync();
+        using (var seed = inner.CreateCommand())
+        {
+            seed.CommandText = "CREATE TABLE t (value INTEGER); INSERT INTO t VALUES (0)";
+            seed.ExecuteNonQuery();
+        }
+        var writer = new Mock<IAuditWriter>();
+        writer.Setup(w => w.WriteAsync(It.IsAny<ZB.MOM.WW.Audit.AuditEvent>(), It.IsAny<CancellationToken>()))
+            .Returns(Task.CompletedTask);
+        await using var connection = new AuditingDbConnection(inner, writer.Object, "db", "site", "instance",
+            "script", NullLogger.Instance, Guid.NewGuid());
+        await using var transaction = asynchronous
+            ? await connection.BeginTransactionAsync()
+            : connection.BeginTransaction();
+        Assert.Same(connection, transaction.Connection);
+        using var command = transaction.Connection!.CreateCommand();
+        Assert.Same(connection, command.Connection);
+        command.Transaction = transaction;
+        Assert.Same(transaction, command.Transaction);
+        Assert.Same(connection, command.Transaction!.Connection);
+        command.CommandText = "UPDATE t SET value = 42";
+        Assert.Equal(1, asynchronous ? await command.ExecuteNonQueryAsync() : command.ExecuteNonQuery());
+        if (asynchronous) await transaction.CommitAsync(); else transaction.Commit();
+        writer.Verify(w => w.WriteAsync(It.IsAny<ZB.MOM.WW.Audit.AuditEvent>(), It.IsAny<CancellationToken>()), Times.Once);
+        using var check = inner.CreateCommand();
+        check.CommandText = "SELECT value FROM t";
+        Assert.Equal(42L, check.ExecuteScalar());
+    }
+
+    [Fact]
+    public void SR11_CommandConnectionCannotExposeProvider()
+    {
+        using var inner = new SqliteConnection("Data Source=:memory:");
+        using var connection = new AuditingDbConnection(inner, Mock.Of<IAuditWriter>(), "db", "site", "instance",
+            "script", NullLogger.Instance, Guid.NewGuid());
+        using var command = connection.CreateCommand();
+        Assert.Same(connection, command.Connection);
+    }
+}