Resolve all high-severity architecture review findings

2026-09-09 16:13:58 -04:00
parent 8bfe65512e
commit 146a13238f
192 changed files with 3160 additions and 753 deletions
@@ -83,7 +83,7 @@ public class ControlPlaneAuthEndToEndTests : IAsyncLifetime
    /// </summary>
    private GrpcChannel Channel(string? key, string siteId = "site-a")
    {
-        var options = new GrpcChannelOptions { HttpHandler = _server.CreateHandler() };
+        var options = new GrpcChannelOptions { HttpHandler = _server.CreateHandler() }.WithMessageLimits();
        if (key is not null)
        {
            options.WithSiteCredentials(new FixedPskProvider(key), siteId);
@@ -116,10 +116,25 @@ public class ControlPlaneAuthEndToEndTests : IAsyncLifetime
            IServerStreamWriter<SiteStreamEvent> responseStream,
            ServerCallContext context)
        {
-            await responseStream.WriteAsync(new SiteStreamEvent { CorrelationId = request.CorrelationId });
+            await responseStream.WriteAsync(new SiteStreamEvent
+            {
+                CorrelationId = request.CorrelationId == "large-audit-window"
+                    ? new string('x', 17 * 1024 * 1024)
+                    : request.CorrelationId,
+            });
        }
    }

+    [Fact]
+    public async Task CM1_ControlPlaneChannelReceivesWorstCaseAuditSizedMessage()
+    {
+        using var channel = Channel(SiteKey);
+        var client = new SiteStreamService.SiteStreamServiceClient(channel);
+        using var call = client.SubscribeInstance(new InstanceStreamRequest { CorrelationId = "large-audit-window" });
+        Assert.True(await call.ResponseStream.MoveNext(CancellationToken.None));
+        Assert.Equal(17 * 1024 * 1024, call.ResponseStream.Current.CorrelationId.Length);
+    }
+
    [Fact]
    public async Task CorrectKey_IsAccepted_OnAUnaryCall()
    {