Resolve all high-severity architecture review findings

2026-09-09 16:13:58 -04:00
parent 8bfe65512e
commit 146a13238f
192 changed files with 3160 additions and 753 deletions
@@ -19,6 +19,61 @@ public class SitePairChannelProviderDisposalTests
        Options.Create(new CommunicationOptions()),
        NullLogger<SitePairChannelProvider>.Instance);

+    [Fact]
+    public async Task ApplyThenUnavailable_DoesNotReplayAnAmbiguousOperation()
+    {
+        using var provider = Build();
+        provider.UpdateSite("site-1", "http://localhost:15101", "http://localhost:15102");
+        var effects = 0;
+        var error = await Record.ExceptionAsync(() => provider.ExecuteAsync("site-1", (channel, ct) =>
+        {
+            effects++;
+            if (effects == 1)
+                throw new global::Grpc.Core.RpcException(new global::Grpc.Core.Status(global::Grpc.Core.StatusCode.Unavailable, "response connection lost after apply"));
+            return Task.FromResult(42);
+        }, CancellationToken.None));
+        Assert.Equal(1, effects);
+        Assert.NotNull(error);
+    }
+
+    [Fact]
+    public async Task SecondaryAppliesThenLosesResponse_AlsoReportsUnknownWithoutAnotherReplay()
+    {
+        using var provider = Build();
+        provider.UpdateSite("site-1", "http://localhost:15101", "http://localhost:15102");
+        var attempts = 0;
+        var effects = 0;
+        var error = await Assert.ThrowsAsync<global::Grpc.Core.RpcException>(() => provider.ExecuteAsync<int>("site-1", (channel, ct) =>
+        {
+            if (++attempts == 1) throw GrpcRetrySafety.NotDispatched("starting");
+            effects++;
+            throw new global::Grpc.Core.RpcException(new global::Grpc.Core.Status(global::Grpc.Core.StatusCode.Unavailable, "applied, reply lost"));
+        }, CancellationToken.None));
+        Assert.Equal(global::Grpc.Core.StatusCode.Aborted, error.StatusCode);
+        Assert.Contains("OUTCOME_UNKNOWN", error.Status.Detail);
+        Assert.Equal(2, attempts);
+        Assert.Equal(1, effects);
+    }
+
+    [Theory]
+    [InlineData(false)]
+    [InlineData(true)]
+    public async Task SafeReadOrExplicitPreDispatchRejection_CanRetry(bool safeRead)
+    {
+        using var provider = Build();
+        provider.UpdateSite("site-1", "http://localhost:15101", "http://localhost:15102");
+        var attempts = 0;
+        var result = await provider.ExecuteAsync("site-1", (channel, ct) =>
+        {
+            if (++attempts == 1)
+                throw safeRead ? new global::Grpc.Core.RpcException(new global::Grpc.Core.Status(global::Grpc.Core.StatusCode.Unavailable, "lost reply"))
+                    : GrpcRetrySafety.NotDispatched("not ready");
+            return Task.FromResult(42);
+        }, CancellationToken.None, retrySafe: safeRead);
+        Assert.Equal(42, result);
+        Assert.Equal(2, attempts);
+    }
+
    [Fact]
    public async Task UpdateSite_WhileCallInFlight_ParksTheOldChannelAndLetsTheCallComplete()
    {