Resolve all high-severity architecture review findings

2026-09-09 16:13:58 -04:00
parent 8bfe65512e
commit 146a13238f
192 changed files with 3160 additions and 753 deletions
@@ -81,6 +81,7 @@ public class AuditLogPagePermissionTests : BunitContext
        var user = BuildPrincipal(roles);
        Services.AddSingleton<AuthenticationStateProvider>(new TestAuthStateProvider(user));
        Services.AddAuthorizationCore();
+        Services.AddTestConfigurationMutations();
        AuthorizationPolicies.AddScadaBridgeAuthorization(Services);
        Services.AddSingleton<IAuthorizationService, DefaultAuthorizationService>();
        WireUpPageDependencies();
@@ -55,6 +55,7 @@ public class AuditLogPageScaffoldTests : BunitContext
        var user = BuildPrincipal(roles);
        Services.AddSingleton<AuthenticationStateProvider>(new TestAuthStateProvider(user));
        Services.AddAuthorizationCore();
+        Services.AddTestConfigurationMutations();
        AuthorizationPolicies.AddScadaBridgeAuthorization(Services);
        Services.AddSingleton<IAuthorizationService, DefaultAuthorizationService>();
        // The page now hosts AuditFilterBar + AuditResultsGrid which depend on
@@ -92,6 +93,7 @@ public class AuditLogPageScaffoldTests : BunitContext
        var user = BuildPrincipal(roles);
        Services.AddSingleton<AuthenticationStateProvider>(new TestAuthStateProvider(user));
        Services.AddAuthorizationCore();
+        Services.AddTestConfigurationMutations();
        AuthorizationPolicies.AddScadaBridgeAuthorization(Services);
        Services.AddSingleton<IAuthorizationService, DefaultAuthorizationService>();

@@ -64,6 +64,7 @@ public class AuditLogPageTrendTests : BunitContext
        var user = BuildPrincipal("Administrator");
        Services.AddSingleton<AuthenticationStateProvider>(new TestAuthStateProvider(user));
        Services.AddAuthorizationCore();
+        Services.AddTestConfigurationMutations();
        AuthorizationPolicies.AddScadaBridgeAuthorization(Services);
        Services.AddSingleton<IAuthorizationService, DefaultAuthorizationService>();

@@ -104,6 +104,7 @@ public class TransportExportPageTests : BunitContext
        var principal = BuildPrincipal("alice", "Designer");
        Services.AddSingleton<AuthenticationStateProvider>(new TestAuthStateProvider(principal));
        Services.AddAuthorizationCore();
+        Services.AddTestConfigurationMutations();
    }

    private static ClaimsPrincipal BuildPrincipal(string username, params string[] roles)
@@ -87,6 +87,7 @@ public class TransportImportPageTests : BunitContext
        var principal = BuildPrincipal("alice", "Administrator");
        Services.AddSingleton<AuthenticationStateProvider>(new TestAuthStateProvider(principal));
        Services.AddAuthorizationCore();
+        Services.AddTestConfigurationMutations();
    }

    private static ClaimsPrincipal BuildPrincipal(string username, params string[] roles)
@@ -146,6 +146,7 @@ public class TransportImportSessionDisposeRaceTests : BunitContext
        var principal = new ClaimsPrincipal(new ClaimsIdentity(claims, "TestAuth"));
        Services.AddSingleton<AuthenticationStateProvider>(new TestAuthStateProvider(principal));
        Services.AddAuthorizationCore();
+        Services.AddTestConfigurationMutations();
    }

    private static void SetField(object obj, string name, object? value) =>
@@ -37,6 +37,7 @@ public class ExecutionTreePageTests : BunitContext
        var user = BuildPrincipal(roles);
        Services.AddSingleton<AuthenticationStateProvider>(new TestAuthStateProvider(user));
        Services.AddAuthorizationCore();
+        Services.AddTestConfigurationMutations();
        AuthorizationPolicies.AddScadaBridgeAuthorization(Services);
        Services.AddSingleton<IAuthorizationService, DefaultAuthorizationService>();
        Services.AddSingleton(_queryService);
@@ -117,6 +117,7 @@ public class HealthPageTests : BunitContext
        var user = new ClaimsPrincipal(new ClaimsIdentity(claims, "TestAuth"));
        Services.AddSingleton<AuthenticationStateProvider>(new TestAuthStateProvider(user));
        Services.AddAuthorizationCore();
+        Services.AddTestConfigurationMutations();
        // The failover control's AuthorizeView evaluates the named RequireAdmin policy, so the
        // real policy set has to be registered or the page throws on any card that renders it.
        AuthorizationPolicies.AddScadaBridgeAuthorization(Services);
@@ -101,6 +101,7 @@ public class NotificationKpisPageTests : BunitContext
        var user = new ClaimsPrincipal(new ClaimsIdentity(claims, "TestAuth"));
        Services.AddSingleton<AuthenticationStateProvider>(new TestAuthStateProvider(user));
        Services.AddAuthorizationCore();
+        Services.AddTestConfigurationMutations();
    }

    [Fact]
@@ -43,6 +43,7 @@ public class NotificationListFormTests : BunitContext
        var user = new ClaimsPrincipal(new ClaimsIdentity(claims, "TestAuth"));
        Services.AddSingleton<AuthenticationStateProvider>(new TestAuthStateProvider(user));
        Services.AddAuthorizationCore();
+        Services.AddTestConfigurationMutations();
    }

    [Fact]
@@ -29,6 +29,7 @@ public class NotificationListsPageTests : BunitContext
        var user = new ClaimsPrincipal(new ClaimsIdentity(claims, "TestAuth"));
        Services.AddSingleton<AuthenticationStateProvider>(new TestAuthStateProvider(user));
        Services.AddAuthorizationCore();
+        Services.AddTestConfigurationMutations();
    }

    [Fact]
@@ -94,6 +94,7 @@ public class NotificationReportDetailModalTests : BunitContext
        var user = new ClaimsPrincipal(new ClaimsIdentity(claims, "TestAuth"));
        Services.AddSingleton<AuthenticationStateProvider>(new TestAuthStateProvider(user));
        Services.AddAuthorizationCore();
+        Services.AddTestConfigurationMutations();
        Services.AddScoped<ZB.MOM.WW.ScadaBridge.CentralUI.Auth.SiteScopeService>();
    }

@@ -83,6 +83,7 @@ public class NotificationReportPageTests : BunitContext
        var user = new ClaimsPrincipal(new ClaimsIdentity(claims, "TestAuth"));
        Services.AddSingleton<AuthenticationStateProvider>(new TestAuthStateProvider(user));
        Services.AddAuthorizationCore();
+        Services.AddTestConfigurationMutations();
        // CentralUI-028: the page now injects SiteScopeService — the test user
        // has no SiteId claims, so this resolves to system-wide and the
        // pre-existing test expectations hold.
@@ -253,6 +253,7 @@ public sealed class QueryStringDrillInTests
            var user = new ClaimsPrincipal(new ClaimsIdentity(claims, "TestAuth"));
            Services.AddSingleton<AuthenticationStateProvider>(new TestAuthStateProvider(user));
            Services.AddAuthorizationCore();
+        Services.AddTestConfigurationMutations();
            Services.AddScoped<ZB.MOM.WW.ScadaBridge.CentralUI.Auth.SiteScopeService>();
        }

@@ -314,6 +315,7 @@ public sealed class QueryStringDrillInTests
            var user = new ClaimsPrincipal(new ClaimsIdentity(claims, "TestAuth"));
            Services.AddSingleton<AuthenticationStateProvider>(new TestAuthStateProvider(user));
            Services.AddAuthorizationCore();
+        Services.AddTestConfigurationMutations();
            Services.AddScoped<ZB.MOM.WW.ScadaBridge.CentralUI.Auth.SiteScopeService>();
        }

@@ -400,6 +402,7 @@ public sealed class QueryStringDrillInTests
            var principal = new ClaimsPrincipal(new ClaimsIdentity(claims, "TestAuth"));
            Services.AddSingleton<AuthenticationStateProvider>(new TestAuthStateProvider(principal));
            Services.AddAuthorizationCore();
+        Services.AddTestConfigurationMutations();
        }
    }
 }
@@ -125,6 +125,7 @@ public class SiteCallsReportPageTests : BunitContext
        var user = new ClaimsPrincipal(new ClaimsIdentity(claims, "TestAuth"));
        Services.AddSingleton<AuthenticationStateProvider>(new TestAuthStateProvider(user));
        Services.AddAuthorizationCore();
+        Services.AddTestConfigurationMutations();
        Services.AddScoped<ZB.MOM.WW.ScadaBridge.CentralUI.Auth.SiteScopeService>();
    }

@@ -27,6 +27,7 @@ public class SmsConfigurationPageTests : BunitContext
        var user = new ClaimsPrincipal(new ClaimsIdentity(claims, "TestAuth"));
        Services.AddSingleton<AuthenticationStateProvider>(new TestAuthStateProvider(user));
        Services.AddAuthorizationCore();
+        Services.AddTestConfigurationMutations();
    }

    private const string SecretToken = "super-secret-auth-token";
@@ -26,6 +26,7 @@ public class SmtpConfigurationPageTests : BunitContext
        var user = new ClaimsPrincipal(new ClaimsIdentity(claims, "TestAuth"));
        Services.AddSingleton<AuthenticationStateProvider>(new TestAuthStateProvider(user));
        Services.AddAuthorizationCore();
+        Services.AddTestConfigurationMutations();
    }

    private static SmtpConfiguration Sample() =>
@@ -61,6 +62,8 @@ public class SmtpConfigurationPageTests : BunitContext
    {
        repo.GetAllSmtpConfigurationsAsync()
            .Returns(Task.FromResult<IReadOnlyList<SmtpConfiguration>>(configs.ToList()));
+        foreach (var config in configs)
+            repo.GetSmtpConfigurationByIdAsync(config.Id).Returns(config);
        Services.AddSingleton(repo);
        WireAuth();

@@ -138,6 +141,7 @@ public class SmtpConfigurationPageTests : BunitContext
        repo.GetAllSmtpConfigurationsAsync()
            .Returns(Task.FromResult<IReadOnlyList<SmtpConfiguration>>(
                new List<SmtpConfiguration> { config }));
+        repo.GetSmtpConfigurationByIdAsync(config.Id).Returns(config);
        Services.AddSingleton(repo);
        WireAuth();