Resolve all high-severity architecture review findings

This commit is contained in:
Joseph Doherty
2026-09-09 16:13:58 -04:00
parent 8bfe65512e
commit 146a13238f
192 changed files with 3160 additions and 753 deletions
@@ -104,6 +104,7 @@ public class FlowDebuggerPageTests : BunitContext
Services.AddSingleton<AuthenticationStateProvider>(stubAuth);
Services.AddScoped(_ => new SiteScopeService(stubAuth));
Services.AddAuthorizationCore();
Services.AddTestConfigurationMutations();
}
private sealed class StubAuthStateProvider : AuthenticationStateProvider
@@ -61,6 +61,7 @@ public class InstanceConfigureAuditDrillinTests : BunitContext
Services.AddSingleton<AuthenticationStateProvider>(authProvider);
Services.AddSingleton(new SiteScopeService(authProvider));
Services.AddAuthorizationCore();
Services.AddTestConfigurationMutations();
AuthorizationPolicies.AddScadaBridgeAuthorization(Services);
}
@@ -52,6 +52,7 @@ public class InstanceConfigureBindingBehaviourTests : BunitContext
Services.AddSingleton<AuthenticationStateProvider>(authProvider);
Services.AddSingleton(new SiteScopeService(authProvider));
Services.AddAuthorizationCore();
Services.AddTestConfigurationMutations();
AuthorizationPolicies.AddScadaBridgeAuthorization(Services);
}
@@ -66,7 +66,7 @@ public class InstanceConfigureListOverrideTests
Assert.Contains("ClearListOverride", markup);
// Repository-direct delete (the page only edits InstanceConfigure; no new
// server method) — same pattern as native-alarm-source overrides.
Assert.Contains("DeleteInstanceAttributeOverrideAsync", markup);
Assert.Contains("DeleteInstanceAttributeOverrideCommand", markup);
Assert.Contains("HasOverrideRow", markup);
}
@@ -49,11 +49,11 @@ public class InstanceConfigureNativeAlarmTests
{
var markup = InstanceConfigureMarkup;
Assert.Contains("GetNativeAlarmSourceOverridesByInstanceIdAsync", markup);
Assert.Contains("GetNativeAlarmSourceOverrideAsync", markup);
Assert.Contains("AddInstanceNativeAlarmSourceOverrideAsync", markup);
Assert.Contains("UpdateInstanceNativeAlarmSourceOverrideAsync", markup);
Assert.Contains("DeleteInstanceNativeAlarmSourceOverrideAsync", markup);
Assert.Contains("SaveChangesAsync", markup);
Assert.Contains("ExecuteConfigurationAsync", markup);
Assert.Contains("SetInstanceNativeAlarmSourceOverrideCommand", markup);
Assert.Contains("SetInstanceNativeAlarmSourceOverrideCommand", markup);
Assert.Contains("DeleteInstanceNativeAlarmSourceOverrideCommand", markup);
Assert.DoesNotContain("TemplateEngineRepository.SaveChangesAsync", markup);
Assert.Contains("SaveNativeOverride", markup);
Assert.Contains("ClearNativeOverride", markup);
}
@@ -83,6 +83,7 @@ public class InstanceCreateTemplateFieldTests : BunitContext
Services.AddSingleton<AuthenticationStateProvider>(
new TestAuthStateProvider(new ClaimsPrincipal(new ClaimsIdentity(claims, "TestAuth"))));
Services.AddAuthorizationCore();
Services.AddTestConfigurationMutations();
JSInterop.Mode = JSRuntimeMode.Loose;
}
@@ -83,6 +83,7 @@ public class TopologyDisableConfirmLabelTests : BunitContext
Services.AddSingleton<AuthenticationStateProvider>(
new TestAuthStateProvider(new ClaimsPrincipal(new ClaimsIdentity(claims, "TestAuth"))));
Services.AddAuthorizationCore();
Services.AddTestConfigurationMutations();
JSInterop.Mode = JSRuntimeMode.Loose;
}