dohertj2/ScadaBridge
1
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity

fix(multivalue): MV-11/MV-13 review nits — correct CLI attribute-delete README synopsis; explicit Disabled + dead-branch cleanup in TemplateEdit list editor

Browse Source
This commit is contained in:
Joseph Doherty
2026-06-16 16:27:44 -04:00
parent ae2e1efb1c
commit 100540b153
2 changed files with 6 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/ZB.MOM.WW.ScadaBridge.CLI/README.md
+2 -3
View File
@@ -214,13 +214,12 @@ scadabridge --url <url> template attribute update --id <int> --name <string> --d
Remove an attribute from a template. Remove an attribute from a template.
```sh ```sh
scadabridge --url <url> template attribute delete --template-id <int> --name <string> scadabridge --url <url> template attribute delete --id <int>
``` ```
| Option | Required | Description | | Option | Required | Description |
|--------|----------|-------------| |--------|----------|-------------|
| `--template-id` | yes | Template ID | | `--id` | yes | Attribute ID |
| `--name` | yes | Attribute name to delete |
#### `template alarm add` #### `template alarm add`
src/ZB.MOM.WW.ScadaBridge.CentralUI/Components/Pages/Design/TemplateEdit.razor
+4 -2
View File
@@ -572,9 +572,11 @@
@if (_attrDataType == DataType.List) @if (_attrDataType == DataType.List)
{ {
<div class="col-12"> <div class="col-12">
@* List VALUE stays editable when editing; only DataType/ElementDataType are server-fixed (ShowElementType hides the type select on edit). *@
<AttributeListEditor @bind-ElementDataType="_attrElementDataType" <AttributeListEditor @bind-ElementDataType="_attrElementDataType"
@bind-Rows="_attrListRows" @bind-Rows="_attrListRows"
ShowElementType="@(!editing)" /> ShowElementType="@(!editing)"
Disabled="false" />
</div> </div>
} }
else else
@@ -1591,7 +1593,7 @@
if (dt == DataType.List) if (dt == DataType.List)
{ {
_attrValue = null; _attrValue = null;
if (_attrListRows.Count == 0) _attrListRows = new(); _attrListRows = new();
if (!AttributeValueCodec.IsValidElementType(_attrElementDataType)) if (!AttributeValueCodec.IsValidElementType(_attrElementDataType))
_attrElementDataType = DataType.String; _attrElementDataType = DataType.String;
} }