docs(src): fix CommentChecker findings across src/ — 1,032 → 5 (all false positives)
Comment/XML-doc changes only, no code logic: - strip project-tracking references (WP*, P*-*, row-NN, #NN, Task N) from comments, keeping the explanatory rationale - add missing summaries, <param>, <returns>, <typeparam> and <inheritdoc/> - replace misused <inheritdoc/> with real docs; where <inheritdoc/> was combined with useful remarks, move the rationale into // comments - drop stale replicationActor <param> on DeploymentManagerActor ctor Remaining 5 are false positives (CWE-1236 x2, failures-1, year-0001, M365). Build 0 errors / 0 warnings.
This commit is contained in:
@@ -115,7 +115,7 @@ public static class AuditExportHelpers
|
||||
/// and <see cref="SocketsHttpHandler.ConnectTimeout"/> bounds only the TCP/TLS
|
||||
/// connect phase, not a connected-but-silent server. Reuses
|
||||
/// <see cref="ManagementHttpClient.DefaultConnectTimeout"/> as the standard CLI
|
||||
/// per-call default (arch-review 2026-08-19 P6-8).
|
||||
/// per-call default.
|
||||
/// </summary>
|
||||
public static readonly TimeSpan DefaultHeadersTimeout = ManagementHttpClient.DefaultConnectTimeout;
|
||||
|
||||
@@ -126,7 +126,7 @@ public static class AuditExportHelpers
|
||||
/// hung/crashed server holding the connection open) is bounded rather than
|
||||
/// hanging the CLI forever — the residual gap the timeout-honesty fix
|
||||
/// (<c>ManagementHttpClient.DefaultConnectTimeout</c> doc comment) left in this
|
||||
/// one path (arch-review 2026-08-19 P6-8).
|
||||
/// one path.
|
||||
/// </summary>
|
||||
public static readonly TimeSpan DefaultInactivityTimeout = ManagementHttpClient.DefaultConnectTimeout;
|
||||
|
||||
@@ -204,7 +204,7 @@ public static class AuditExportHelpers
|
||||
// Honour the documented "authorization failure → exit 2"
|
||||
// contract on the REST audit surface as well. HTTP 403 is the
|
||||
// primary signal; the server may also surface UNAUTHORIZED /
|
||||
// FORBIDDEN via the JSON error envelope on a non-403 status.
|
||||
// FORBIDDEN via the JSON error envelope on a status other than 403.
|
||||
var errorCode = TryExtractErrorCode(message);
|
||||
var isAuthFailure = (int)response.StatusCode == 403
|
||||
|| string.Equals(errorCode, "FORBIDDEN", StringComparison.OrdinalIgnoreCase)
|
||||
|
||||
Reference in New Issue
Block a user