dohertj2/ScadaBridge
1
0
Fork 0
Code Issues 1 Pull Requests 1 Actions Packages Projects Releases Wiki Activity

fix(host): dev site seed no longer targets the metrics port; validator rejects seed-vs-MetricsPort

Browse Source
This commit is contained in:
Joseph Doherty
2026-07-08 16:37:43 -04:00
parent d962c77bb7
commit 0e3c1df1a7
3 changed files with 40 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/ZB.MOM.WW.ScadaBridge.Host.Tests/StartupValidatorTests.cs
+30
View File
@@ -319,6 +319,36 @@ public class StartupValidatorTests
Assert.Contains("must not target the gRPC port", ex.Message);
}
[Fact]
public void Site_SeedNodeOnMetricsPort_FailsValidation()
{
// Review 01 [Medium]: appsettings.Site.json shipped a seed pointing at the
// Kestrel HTTP/1.1 metrics listener (8084) — a doomed Akka.Remote
// association. The validator guarded GrpcPort but not MetricsPort.
var values = ValidSiteConfig();
values["ScadaBridge:Node:GrpcPort"] = "8083";
values["ScadaBridge:Node:MetricsPort"] = "8084";
values["ScadaBridge:Cluster:SeedNodes:1"] = "akka.tcp://scadabridge@site-a-node1:8084";
var config = BuildConfig(values);
var ex = Assert.Throws<InvalidOperationException>(() => StartupValidator.Validate(config));
Assert.Contains("must not target the metrics port", ex.Message);
}
[Fact]
public void Site_SeedNodeOnDefaultMetricsPort_FailsValidation()
{
// MetricsPort absent => NodeOptions default 8084. A seed on 8084 must
// still be rejected. Keep GrpcPort distinct so only the metrics rule fires.
var values = ValidSiteConfig();
values["ScadaBridge:Node:GrpcPort"] = "8083";
values["ScadaBridge:Cluster:SeedNodes:1"] = "akka.tcp://scadabridge@site-a-node2:8084";
var config = BuildConfig(values);
var ex = Assert.Throws<InvalidOperationException>(() => StartupValidator.Validate(config));
Assert.Contains("must not target the metrics port", ex.Message);
}
[Fact]
public void Site_SeedNodeOnDefaultGrpcPort_FailsValidation()
{