fix(communication): resolve Communication-009,010,011 — atomic site-cache refresh, XML doc correction, test coverage

src/ScadaLink.Communication/Actors/CentralCommunicationActor.cs

@@ -50,7 +50,7 @@ public class CentralCommunicationActor : ReceiveActor
     /// Maps SiteIdentifier → (ClusterClient actor, set of contact address strings).
     /// Refreshed periodically via RefreshSiteAddresses.
     /// </summary>
-    private Dictionary<string, (IActorRef Client, ImmutableHashSet<string> ContactAddresses)> _siteClients = new();
+    private readonly Dictionary<string, (IActorRef Client, ImmutableHashSet<string> ContactAddresses)> _siteClients = new();
 
     /// <summary>
     /// Tracks active debug view subscriptions: correlationId → (siteId, subscriber).
@@ -262,9 +262,23 @@ public class CentralCommunicationActor : ReceiveActor
         // Add or update
         foreach (var (siteId, addresses) in msg.SiteContacts)
         {
-            var contactPaths = addresses
-                .Select(a => ActorPath.Parse($"{a}/system/receptionist"))
-                .ToImmutableHashSet();
+            // Communication-009: parse all addresses up front inside a try/catch so a
+            // single malformed site row cannot abort the whole refresh loop and leave
+            // the cache half-updated. A bad site is logged and skipped; others proceed.
+            ImmutableHashSet<ActorPath> contactPaths;
+            try
+            {
+                contactPaths = addresses
+                    .Select(a => ActorPath.Parse($"{a}/system/receptionist"))
+                    .ToImmutableHashSet();
+            }
+            catch (Exception ex)
+            {
+                _log.Warning(ex,
+                    "Malformed contact address for site {0}; skipping this site in the refresh "
+                    + "(other sites are unaffected)", siteId);
+                continue;
+            }
 
             var contactStrings = addresses.ToImmutableHashSet();