test(playwright): repair 14 selector-drift failures from two Central UI refactors

All 14 pre-existing Playwright failures triage to selector drift, not rig data,
timing, or application defects — every one is a test-side assumption that two
merged UI refactors invalidated without updating this suite.

`9e243493` (2026-08-11 density sweep + Theme 0.4.1) regrouped page/dialog action
buttons into `btn-group btn-group-sm`, moving the size class off the button and
onto the group. Twelve selectors still pinned `.btn-sm` on the button itself:
ConfigurationAuditLog's Search (4 tests), the Topology Create/Move dialog footers
(3), the Notification Lists row Edit/Delete (2), and the Notification Report row
Retry/Discard (2). The same sweep re-cast SiteForm's per-node subsections from
bare `<h6>` headings to Bootstrap cards, so `h6:has-text('Node A')` matches
nothing (1). Note the swept surfaces are a subset — the recipient table on the
notification-list edit form, OffsetPager, DiffDialog and friends still carry
`.btn-sm` on the button, so the selectors are deliberately asymmetric; the
remaining `.btn-sm` selectors in this suite were each re-verified against current
markup rather than swept along.

`a506b19d` moved TemplateEdit's page-embedded modals onto the DialogService host.
The attribute modal is now the DialogHost modal (`modal fade show d-block`, title
in an h5), so the `:not(.fade)` guard written to exclude DialogHost — plus the
`h6.modal-title` assertion — excluded the very modal under test (2). TemplateEdit
renders no page-local modal any more, so the guard has nothing left to guard.

Comments at each site record why the size class is absent, so a future reader
does not "fix" the selectors back.

Verified: 14 failed / 158 passed baseline -> the 36 tests in the seven affected
classes all green; solution build 0 warnings / 0 errors.
This commit is contained in:
Joseph Doherty
2026-08-15 03:33:51 -04:00
parent 2b74851f96
commit 014038fbbd
7 changed files with 49 additions and 26 deletions
@@ -82,9 +82,12 @@ public class AuditConfigurationTests
await Assertions.Expect(page.Locator("#audit-filter-entity-type")).ToBeVisibleAsync();
// Filter by the unique marker so only this run's 3 rows remain, then
// Search to load the grid.
// Search to load the grid. The Search/Clear pair sits in a
// `btn-group btn-group-sm` since the 2026-08-11 UI density sweep, so the
// size class lives on the group and NOT on the button — do not re-add
// `.btn-sm` to this selector.
await page.Locator("#audit-filter-entity-type").FillAsync(marker);
await page.Locator("button.btn.btn-primary.btn-sm:has-text('Search')").ClickAsync();
await page.Locator("button.btn.btn-primary:has-text('Search')").ClickAsync();
await page.WaitForLoadStateAsync(LoadState.NetworkIdle);
// Seeded rows are isolated: a known row is visible AND the footer total
@@ -116,7 +119,7 @@ public class AuditConfigurationTests
// Filter by the marker so the totals/page-count reflect only this run.
await page.Locator("#audit-filter-entity-type").FillAsync(marker);
await page.Locator("button.btn.btn-primary.btn-sm:has-text('Search')").ClickAsync();
await page.Locator("button.btn.btn-primary:has-text('Search')").ClickAsync();
await page.WaitForLoadStateAsync(LoadState.NetworkIdle);
// Page 1 of 2: Previous disabled, Next enabled. (M10 OffsetPager summary:
@@ -161,7 +164,7 @@ public class AuditConfigurationTests
// Filter by the unique marker and Search so only this run's single
// large-state row populates the grid.
await page.Locator("#audit-filter-entity-type").FillAsync(marker);
await page.Locator("button.btn.btn-primary.btn-sm:has-text('Search')").ClickAsync();
await page.Locator("button.btn.btn-primary:has-text('Search')").ClickAsync();
await page.WaitForLoadStateAsync(LoadState.NetworkIdle);
// Open the modal from the seeded large-state row. The marker is unique,
@@ -198,7 +201,7 @@ public class AuditConfigurationTests
await page.WaitForLoadStateAsync(LoadState.NetworkIdle);
await page.Locator("#audit-filter-entity-type").FillAsync(marker);
await page.Locator("button.btn.btn-primary.btn-sm:has-text('Search')").ClickAsync();
await page.Locator("button.btn.btn-primary:has-text('Search')").ClickAsync();
await page.WaitForLoadStateAsync(LoadState.NetworkIdle);
// Click the copy-entity-ID button on the (only) seeded row.