dohertj2/ScadaBridge
1
0
Fork 0
Code Issues 2 Pull Requests Actions Packages Projects Releases Wiki Activity

docs(management): DebugStreamHub comments name bearer + Basic auth (review 2026-10-21 lane K follow-up)

Browse Source
This commit is contained in:
Joseph Doherty
2026-10-22 09:28:16 -04:00
parent 52c8a212a1
commit 008976f3d8
1 changed files with 7 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/ZB.MOM.WW.ScadaBridge.ManagementService/DebugStreamHub.cs
+7 -6
View File
@@ -11,8 +11,9 @@ namespace ZB.MOM.WW.ScadaBridge.ManagementService;
/// <summary> /// <summary>
/// SignalR hub for real-time debug stream subscriptions. /// SignalR hub for real-time debug stream subscriptions.
/// External consumers (CLI) connect via WebSocket, authenticate with Basic Auth, /// External consumers (CLI) connect via WebSocket, authenticate through
/// and receive streaming attribute value and alarm state changes. /// <see cref="ManagementAuthenticator"/> — a bearer JWT minted by <c>POST /auth/token</c>, or
/// HTTP Basic (LDAP bind) — and receive streaming attribute value and alarm state changes.
/// </summary> /// </summary>
public class DebugStreamHub : Hub public class DebugStreamHub : Hub
{ {
@@ -74,10 +75,10 @@ public class DebugStreamHub : Hub
return; return;
} }
// Authenticate via the SAME shared Basic→LDAP flow as POST /management and the // Authenticate via the SAME shared flow as POST /management and the audit REST
// audit REST (arch-review R2 N1): ManagementAuthenticator applies the DisableLogin // (arch-review R2 N1): ManagementAuthenticator applies the DisableLogin bypass, accepts
// bypass, the LoginThrottle lockout check BEFORE the bind, and RecordFailure/ // a bearer JWT (no LDAP bind) or Basic→LDAP with the LoginThrottle lockout check
// RecordSuccess bookkeeping — so hub connection attempts can no longer be used as // BEFORE the bind, and RecordFailure/RecordSuccess bookkeeping — so hub connection attempts can no longer be used as
// an unthrottled LDAP-bind oracle, and hub failures feed the shared lockout. // an unthrottled LDAP-bind oracle, and hub failures feed the shared lockout.
var outcome = await ManagementAuthenticator.AuthenticateAsync(httpContext); var outcome = await ManagementAuthenticator.AuthenticateAsync(httpContext);
if (outcome.User is null) if (outcome.User is null)