Implement in-process multi-dataset sync isolation across core, network, persistence, and tests

2026-02-22 11:58:34 -05:00
parent c06b56172a
commit 8e97061ab8
60 changed files with 4519 additions and 559 deletions
--- a/tests/ZB.MOM.WW.CBDDC.Network.Tests/MultiDatasetSyncOrchestratorTests.cs
+++ b/tests/ZB.MOM.WW.CBDDC.Network.Tests/MultiDatasetSyncOrchestratorTests.cs
@@ -0,0 +1,102 @@
+using Microsoft.Extensions.Logging.Abstractions;
+using ZB.MOM.WW.CBDDC.Core;
+using ZB.MOM.WW.CBDDC.Core.Network;
+using ZB.MOM.WW.CBDDC.Core.Storage;
+
+namespace ZB.MOM.WW.CBDDC.Network.Tests;
+
+public class MultiDatasetSyncOrchestratorTests
+{
+    [Fact]
+    public void Constructor_WhenMultiDatasetDisabled_ShouldOnlyCreatePrimaryContext()
+    {
+        var sut = CreateSut(
+            [
+                new DatasetSyncOptions { DatasetId = DatasetId.Primary, Enabled = true },
+                new DatasetSyncOptions { DatasetId = DatasetId.Logs, Enabled = true }
+            ],
+            new MultiDatasetRuntimeOptions
+            {
+                EnableMultiDatasetSync = false,
+                EnableDatasetPrimary = true,
+                EnableDatasetLogs = true
+            });
+
+        var datasetIds = sut.Contexts.Select(c => c.DatasetId).ToList();
+        datasetIds.Count.ShouldBe(1);
+        datasetIds[0].ShouldBe(DatasetId.Primary);
+    }
+
+    [Fact]
+    public async Task StartStop_WhenOneDatasetThrows_ShouldContinueOtherDatasets()
+    {
+        var orchestrators = new Dictionary<string, TrackingSyncOrchestrator>(StringComparer.Ordinal)
+        {
+            [DatasetId.Primary] = new TrackingSyncOrchestrator(),
+            [DatasetId.Logs] = new TrackingSyncOrchestrator(startException: new InvalidOperationException("boom")),
+            [DatasetId.Timeseries] = new TrackingSyncOrchestrator()
+        };
+
+        var sut = CreateSut(
+            [],
+            new MultiDatasetRuntimeOptions
+            {
+                EnableMultiDatasetSync = true,
+                EnableDatasetPrimary = true,
+                EnableDatasetLogs = true,
+                EnableDatasetTimeseries = true
+            },
+            options => orchestrators[DatasetId.Normalize(options.DatasetId)]);
+
+        await sut.Start();
+        await sut.Stop();
+
+        orchestrators[DatasetId.Primary].StartCalls.ShouldBe(1);
+        orchestrators[DatasetId.Primary].StopCalls.ShouldBe(1);
+
+        orchestrators[DatasetId.Logs].StartCalls.ShouldBe(1);
+        orchestrators[DatasetId.Logs].StopCalls.ShouldBe(1);
+
+        orchestrators[DatasetId.Timeseries].StartCalls.ShouldBe(1);
+        orchestrators[DatasetId.Timeseries].StopCalls.ShouldBe(1);
+    }
+
+    private static MultiDatasetSyncOrchestrator CreateSut(
+        IEnumerable<DatasetSyncOptions> datasetOptions,
+        MultiDatasetRuntimeOptions runtimeOptions,
+        Func<DatasetSyncOptions, ISyncOrchestrator>? orchestratorFactory = null)
+    {
+        return new MultiDatasetSyncOrchestrator(
+            Substitute.For<IDiscoveryService>(),
+            Substitute.For<IOplogStore>(),
+            Substitute.For<IDocumentStore>(),
+            Substitute.For<ISnapshotMetadataStore>(),
+            Substitute.For<ISnapshotService>(),
+            Substitute.For<IPeerNodeConfigurationProvider>(),
+            NullLoggerFactory.Instance,
+            datasetOptions,
+            runtimeOptions,
+            orchestratorFactory: orchestratorFactory);
+    }
+
+    private sealed class TrackingSyncOrchestrator(Exception? startException = null, Exception? stopException = null)
+        : ISyncOrchestrator
+    {
+        public int StartCalls { get; private set; }
+        public int StopCalls { get; private set; }
+
+        public Task Start()
+        {
+            StartCalls++;
+            if (startException != null) throw startException;
+            return Task.CompletedTask;
+        }
+
+        public Task Stop()
+        {
+            StopCalls++;
+            if (stopException != null) throw stopException;
+            return Task.CompletedTask;
+        }
+    }
+}